Add tests to pkg/commands/git - Part 7 #291
Conversation
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
==========================================
+ Coverage 94.83% 95.28% +0.44%
==========================================
Files 9 9
Lines 1550 1547 -3
==========================================
+ Hits 1470 1474 +4
+ Misses 78 72 -6
+ Partials 2 1 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
==========================================
+ Coverage 93.63% 94.02% +0.39%
==========================================
Files 12 12
Lines 1633 1624 -9
==========================================
- Hits 1529 1527 -2
+ Misses 101 95 -6
+ Partials 3 2 -1
Continue to review full report at Codecov.
|
|
@jesseduffield could you review pls ? |
pkg/commands/git.go
Outdated
| } | ||
|
|
||
| // Diff returns the diff of a file | ||
| func (c *GitCommand) Diff(file File) string { | ||
| cachedArg := "" | ||
| trackedArg := "--" |
There was a problem hiding this comment.
I'm not sure what the common convention is, but from my perspective it's hard to know what a variable represents until you see it get used, so I'm not sure what the use of declaring variables at the top of the function is, when you're not going to know what they're used for until later on
There was a problem hiding this comment.
In my opinion it's easier to see variables defined in the function at the top, it's your initial state, you know this is what's in use in the whole function and if you don't go through any condition, the value is what you will get. If you have many variable and a long function, it could be hard to check where a variable is defined to get its initial value. Here you know everything is at the top so it eases the look up. I would say it's not an absolute rule as usual you have case where it's not ok but I think here it fits well.
| @@ -1,35 +0,0 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
it looks like this file covers more test cases than is covered in this PR
There was a problem hiding this comment.
To know if a test cover a function you have to look at codecov, https://codecov.io/gh/jesseduffield/lazygit/pull/291/src/pkg/commands/git.go?before=pkg/commands/git.go :
You have less cases but it covers every branches in function
|
I forgot to ping again @jesseduffield |
No description provided.