Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix initial origin of editor box #2146

Merged

Conversation

Ryooooooga
Copy link
Contributor

@Ryooooooga Ryooooooga commented Sep 1, 2022

  • PR Description

When trying to reword a commit with a multi-line message, only the last line is displayed in the edit box.

To reproduce

  1. commit changes with multi-line message: git commit -m "$(seq 100)" --allow-empty

  2. launch lazygit

  3. move to Commits panel (3), reword latest commit (r)

before
スクリーンショット 2022-09-01 19 44 56

after
スクリーンショット 2022-09-01 19 45 05

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@jesseduffield jesseduffield merged commit 46b08e7 into jesseduffield:master Sep 7, 2022
@jesseduffield
Copy link
Owner

awesome work!

@Ryooooooga Ryooooooga deleted the fix-initial-origin-editor branch September 9, 2022 01:16
stefanhaller added a commit that referenced this pull request Jun 27, 2024
The only purpose of this was to scroll the editable text correctly (see
#2146); now that gocui takes care
of that, we no longer need to do this.
stefanhaller added a commit that referenced this pull request Jun 28, 2024
The only purpose of this was to scroll the editable text correctly (see
#2146); now that gocui takes care
of that, we no longer need to do this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants