lazygit --debug --> Potential Deadlock

[1Jo1]

Describe the bug
when I execute lazygit --debug:

tenet@jobackend:  lazygit --debug
POTENTIAL DEADLOCK: Recursive locking:
current goroutine 2 lock 0xc0002a33d0
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:504 helpers.(*RefreshHelper).refreshBranches ??? <<<<<
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:503 helpers.(*RefreshHelper).refreshBranches ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:273 helpers.(*RefreshHelper).refreshReflogAndBranches ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:129 helpers.(*RefreshHelper).Refresh.func2.2 ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:107 helpers.(*RefreshHelper).Refresh.func2.1.1 ???
github.com/jesseduffield/gocui@v0.3.1-0.20240906064314-bfab49c720d7/gui.go:702 gocui.(*Gui).onWorkerAux ???
github.com/jesseduffield/gocui@v0.3.1-0.20240906064314-bfab49c720d7/task.go:22 gocui.(*TaskImpl).Done ???

Previous place where the lock was grabbed (same goroutine)
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:322 helpers.(*RefreshHelper).refreshCommitsWithLimit ??? <<<<<
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:321 helpers.(*RefreshHelper).refreshCommitsWithLimit ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:277 helpers.(*RefreshHelper).refreshCommitsAndCommitFiles ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:107 helpers.(*RefreshHelper).Refresh.func2.1.1 ???
github.com/jesseduffield/gocui@v0.3.1-0.20240906064314-bfab49c720d7/gui.go:702 gocui.(*Gui).onWorkerAux ???
github.com/jesseduffield/gocui@v0.3.1-0.20240906064314-bfab49c720d7/task.go:22 gocui.(*TaskImpl).Done ???

Other goroutines holding locks:
goroutine 2 lock 0xc0002a33c0
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:442 helpers.(*RefreshHelper).refreshBranches ??? <<<<<
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:441 helpers.(*RefreshHelper).refreshBranches ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:273 helpers.(*RefreshHelper).refreshReflogAndBranches ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:129 helpers.(*RefreshHelper).Refresh.func2.2 ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:107 helpers.(*RefreshHelper).Refresh.func2.1.1 ???
github.com/jesseduffield/gocui@v0.3.1-0.20240906064314-bfab49c720d7/gui.go:702 gocui.(*Gui).onWorkerAux ???
github.com/jesseduffield/gocui@v0.3.1-0.20240906064314-bfab49c720d7/task.go:22 gocui.(*TaskImpl).Done ???

goroutine 2 lock 0xc0002a33b8
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:512 helpers.(*RefreshHelper).refreshFilesAndSubmodules ??? <<<<<
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:511 helpers.(*RefreshHelper).refreshFilesAndSubmodules ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:154 helpers.(*RefreshHelper).Refresh.func2.8 ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:107 helpers.(*RefreshHelper).Refresh.func2.1.1 ???
github.com/jesseduffield/gocui@v0.3.1-0.20240906064314-bfab49c720d7/gui.go:702 gocui.(*Gui).onWorkerAux ???
github.com/jesseduffield/gocui@v0.3.1-0.20240906064314-bfab49c720d7/task.go:22 gocui.(*TaskImpl).Done ???

To Reproduce
see you above

Version info:
commit=v0.44.1, build date=2024-09-18T13:19:48Z, build source=binaryRelease, version=0.44.1, os=linux, arch=amd64, git version=2.47.0

[1Jo1]

same issue with the newest lazygit version

tenet@jobackend   fix-husky lazygit --version
commit=095eb130e, build date=20241021.092648, build source=unknown, version=v0.44.1.095eb130e, os=linux, arch=amd64, git version=2.47.0
tenet@jobackend   fix-husky lazygit --debug
POTENTIAL DEADLOCK: Recursive locking:
current goroutine 2 lock 0xc00011d0b0
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:505 helpers.(*RefreshHelper).refreshBranches ??? <<<<<
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:504 helpers.(*RefreshHelper).refreshBranches ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:273 helpers.(*RefreshHelper).refreshReflogAndBranches ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:129 helpers.(*RefreshHelper).Refresh.func2.2 ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:107 helpers.(*RefreshHelper).Refresh.func2.1.1 ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/vendor/github.com/jesseduffield/gocui/gui.go:702 gocui.(*Gui).onWorkerAux ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/vendor/github.com/jesseduffield/gocui/task.go:22 gocui.(*TaskImpl).Done ???

Previous place where the lock was grabbed (same goroutine)
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:322 helpers.(*RefreshHelper).refreshCommitsWithLimit ??? <<<<<
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:321 helpers.(*RefreshHelper).refreshCommitsWithLimit ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:277 helpers.(*RefreshHelper).refreshCommitsAndCommitFiles ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:107 helpers.(*RefreshHelper).Refresh.func2.1.1 ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/vendor/github.com/jesseduffield/gocui/gui.go:702 gocui.(*Gui).onWorkerAux ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/vendor/github.com/jesseduffield/gocui/task.go:22 gocui.(*TaskImpl).Done ???

Other goroutines holding locks:
goroutine 2 lock 0xc00011d0a0
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:447 helpers.(*RefreshHelper).refreshBranches ??? <<<<<
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:446 helpers.(*RefreshHelper).refreshBranches ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:273 helpers.(*RefreshHelper).refreshReflogAndBranches ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:129 helpers.(*RefreshHelper).Refresh.func2.2 ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:107 helpers.(*RefreshHelper).Refresh.func2.1.1 ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/vendor/github.com/jesseduffield/gocui/gui.go:702 gocui.(*Gui).onWorkerAux ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/vendor/github.com/jesseduffield/gocui/task.go:22 gocui.(*TaskImpl).Done ???

goroutine 2 lock 0xc00011d098
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:513 helpers.(*RefreshHelper).refreshFilesAndSubmodules ??? <<<<<
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:512 helpers.(*RefreshHelper).refreshFilesAndSubmodules ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:154 helpers.(*RefreshHelper).Refresh.func2.8 ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:107 helpers.(*RefreshHelper).Refresh.func2.1.1 ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/vendor/github.com/jesseduffield/gocui/gui.go:702 gocui.(*Gui).onWorkerAux ???
~/.cache/yay/lazygit-git/src/src/github.com/jesseduffield/lazygit/vendor/github.com/jesseduffield/gocui/task.go:22 gocui.(*TaskImpl).Done ???

[willparsons]

This seems to only occur when using go 1.23, just tested 1.22 and it works fine.

I'm not really familiar with the changes in 1.23 so I'm not sure why this version doesn't work.

[1Jo1]

same for me :) maybe some breaking changes in 1.23

[moha-gh]

Also affected by this. What makes this worse for me is that the DevContainer defaults to the latest Go version - and thus you end up with 1.23 as of now. I managed to switch to 1.22 in the container by modifying

lazygit/.devcontainer/Dockerfile

Line 4 in e1e4e1b

ARG VARIANT=1-bullseye

to

ARG VARIANT=1.22-bullseye

and

lazygit/.devcontainer/devcontainer.json

Line 16 in e1e4e1b

"version": "none"

to

          "version": "1.22"

Only making the latter change somehow resulted in a broken installation that complained about iter imports somewhere in the dependency chain (a feature only added in 1.23).

[stefanhaller]

Looks like this was fixed with #4248.