Fix infinite wait on push/pull on windows (#2821)

jesseduffield · web-flow · commit 94426de533e6 · 2023-07-24T21:14:51.000+10:00
diff --git a/pkg/commands/oscommands/cmd_obj_runner.go b/pkg/commands/oscommands/cmd_obj_runner.go
@@ -312,7 +312,9 @@ func (self *cmdObjRunner) runAndDetectCredentialRequest(
 	return self.runAndStreamAux(cmdObj, func(handler *cmdHandler, cmdWriter io.Writer) {
 		tr := io.TeeReader(handler.stdoutPipe, cmdWriter)
 
-		self.processOutput(tr, handler.stdinPipe, promptUserForCredential, cmdObj.GetTask())
+		go utils.Safe(func() {
+			self.processOutput(tr, handler.stdinPipe, promptUserForCredential, cmdObj.GetTask())
+		})
 	})
 }
 

Original file line number	Diff line number	Diff line change
`@@ -312,7 +312,9 @@ func (self *cmdObjRunner) runAndDetectCredentialRequest(`
`312`	`312`	`return self.runAndStreamAux(cmdObj, func(handler *cmdHandler, cmdWriter io.Writer) {`
`313`	`313`	`tr := io.TeeReader(handler.stdoutPipe, cmdWriter)`
`314`	`314`
`315`		`- self.processOutput(tr, handler.stdinPipe, promptUserForCredential, cmdObj.GetTask())`
	`315`	`+ go utils.Safe(func() {`
	`316`	`+ self.processOutput(tr, handler.stdinPipe, promptUserForCredential, cmdObj.GetTask())`
	`317`	`+ })`
`316`	`318`	`})`
`317`	`319`	`}`
`318`	`320`