Skip to content

Commit c28e891

Browse files
committed
Fix Windows Node.js download URL - use win-x64 instead of win32-x64
1 parent 22d5839 commit c28e891

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

.github/workflows/build-and-release.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ jobs:
228228
run: |
229229
PLATFORM="win32-x64"
230230
NODE_VERSION="v20.11.0"
231-
NODE_ARCH="win32-x64"
231+
NODE_DOWNLOAD_ARCH="win-x64"
232232
233233
mkdir -p output/${PLATFORM}
234234
@@ -244,12 +244,14 @@ jobs:
244244
--external:vscode-jsonrpc \
245245
--external:dotenv
246246
247-
# Download Node.js runtime
248-
NODE_PKG="node-${NODE_VERSION}-${NODE_ARCH}"
247+
# Download Node.js runtime (Windows uses 'win-x64' not 'win32-x64')
248+
NODE_PKG="node-${NODE_VERSION}-${NODE_DOWNLOAD_ARCH}"
249249
NODE_URL="https://nodejs.org/dist/${NODE_VERSION}/${NODE_PKG}.zip"
250-
curl -L "${NODE_URL}" -o /tmp/${NODE_PKG}.zip
251-
unzip -q /tmp/${NODE_PKG}.zip -d /tmp/
252-
mv /tmp/${NODE_PKG} output/${PLATFORM}/node
250+
echo "Downloading: ${NODE_URL}"
251+
curl -fsSL "${NODE_URL}" -o "${NODE_PKG}.zip"
252+
unzip -q "${NODE_PKG}.zip" -d "output/${PLATFORM}/"
253+
mv "output/${PLATFORM}/${NODE_PKG}" "output/${PLATFORM}/node"
254+
rm -f "${NODE_PKG}.zip"
253255
254256
# Strip unnecessary files from Node.js
255257
cd output/${PLATFORM}/node

0 commit comments

Comments
 (0)