Fix regexp character classes with \uNNNN and \xNN code points #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosthekiss
added
bug
|
What is the problem exactly? |
|
It's described in #962, as mentioned in the first comment. (In short: if a regexp contains a character class, and that character class contains a hex-specified code point -- either \uNNNN or \xNN --, then the current implementation incorrectly adds the character 'u' or 'x' to the character class as well.) |
|
LGTM. I think in such cases it is better to describe the problem in the commit log as well. |
Currently, if a regexp contains a character class and that character class contains a hex-specified code point -- either \uNNNN or \xNN --, then the character 'u' or 'x' is added to the character class as well. This patch fixes the error and also adds a regression test covering the issue. Fixes jerryscript-project#962 JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
akosthekiss
force-pushed
the
regex-char-class-uxcode-fix
branch
from
25eb636 to
57db5ca
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adding a regression test covering the issue.
Fixes #962
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu