Skip to content

Add jerry_port_get_time API and use it for Date.now() #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add jerry_port_get_time API and use it for Date.now() #969

wants to merge 1 commit into from

Conversation

franc0is
Copy link
Contributor

JerryScript-DCO-1.0-Signed-off-by: François Baldassari francois@pebble.com

@franc0is franc0is force-pushed the jerry-port-date branch 2 times, most recently from b6df2ba to 4f923a9 Compare March 18, 2016 00:45
Add jerry_port_get_time API and use it for Date.now()
8eceed0 
JerryScript-DCO-1.0-Signed-off-by: François Baldassari francois@pebble.com
@LaszloLango
Copy link
Contributor

What is the motivation of this patch? If you want to move date related functions to jerry port, then you need to move ecma_date_local_tza and ecma_date_daylight_saving_ta too.

@LaszloLango LaszloLango added jerry-port Related to the port API or the default port implementation development Feature implementation labels Mar 18, 2016
@franc0is
Copy link
Contributor Author

The system I am porting jerryscript to isnt POSIX and does not provide
gettimeofday, the port API seemed like the right place to hold such
platform dependent code.

You are correct on the second part and I do intend to move those those
other function as well (little by little).

I thought I'd start small so that we'd have this conversation before I went
too far down this road.

On Friday, March 18, 2016, László Langó notifications@github.com wrote:

What is the motivation of this patch? If you want to move date related
functions to jerry port, then you need to move ecma_date_local_tza and
ecma_date_daylight_saving_ta too.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#969 (comment)

@LaszloLango LaszloLango mentioned this pull request Mar 18, 2016
Closed
This was referenced Apr 18, 2016
Merged
Merged
@franc0is
Copy link
Contributor Author

Superceded by #1018

@franc0is franc0is closed this Apr 21, 2016
@franc0is franc0is deleted the jerry-port-date branch April 21, 2016 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
development Feature implementation jerry-port Related to the port API or the default port implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franc0is @LaszloLango