Implement Array.prototoype.toLocaleString() #96
Conversation
|
@dbatyai, please take a look. |
|
lgtm |
| uint32_t length = ecma_number_to_uint32 (length_number); | ||
|
|
||
| /* 4. */ | ||
| ecma_string_t *separator_string_p = ecma_get_magic_string (ECMA_MAGIC_STRING_COMMA_CHAR); |
There was a problem hiding this comment.
How the separator was choosed?
Please, add comment with description, reminding that this is implementation-defined.
Maybe we should introduce some mark for implementation-defined places, that can be easily found with grep,
something like "Implementation-defined" string.
Later we should add a documentation paragraph that would list all the places, and maybe introduce some configuration options for them.
There was a problem hiding this comment.
Ok, good point, will do the update.
galpeter
force-pushed
the
array_prototype_tolocalestring
branch
from
9b576ed to
538fa81
Compare
|
@ruben-ayrapetyan, I've update the pull request. |
|
@ruben-ayrapetyan recheck me, please |
| * The Array.prototype's 'toLocaleString' single element operation routine | ||
| * | ||
| * See also: | ||
| * ECMA-262 v5, 15.4.4.3 steps 7-8 and 10.b-d |
There was a problem hiding this comment.
It seems that steps 6-8 and 10.b-d or steps 7-8 and 10.c-d would be more correct,
as both steps 6 and 10.b perform [[Get]].
There was a problem hiding this comment.
Ahh, yeah, I think then we should go with the steps 6-8 and 10.b-d
|
Please, update the comment and |
galpeter
force-pushed
the
array_prototype_tolocalestring
branch
2 times, most recently
from
4e51dab to
08561f2
Compare
JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com
galpeter
force-pushed
the
array_prototype_tolocalestring
branch
from
08561f2 to
aaeec7f
Compare
JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com