Implemented Array.prototype.sort() #95
Conversation
dbatyai
force-pushed
the
array_prototype_sort
branch
2 times, most recently
from
f939751 to
233dd6e
Compare
| ecma_value_t comparefn) /**< compare function */ | ||
| { | ||
| ecma_completion_value_t ret_value = ecma_make_empty_completion_value (); | ||
| int child = 2 * index; |
dbatyai
force-pushed
the
array_prototype_sort
branch
from
233dd6e to
0fd2a85
Compare
|
Hi @egavrin, |
| * Loop ended, either current child does not exist, or is less than swap. | ||
| * This means that 'swap' should be placed in the parent node. | ||
| */ | ||
| array[(child - 1) / 2] = swap; |
There was a problem hiding this comment.
@dbatyai, could you, please, add assertions with bound checking in the function?
dbatyai
force-pushed
the
array_prototype_sort
branch
from
0fd2a85 to
761c079
Compare
|
@ruben-ayrapetyan, I've added asserts to make sure we stay in bounds. |
|
@dbatyai, thank you! |
|
May we push it? |
| * sort to the end of the result, followed by non-existent property values. | ||
| */ | ||
| ecma_completion_value_t ret_value = ecma_make_empty_completion_value (); | ||
| ecma_number_t *result = ecma_alloc_number (); |
There was a problem hiding this comment.
Please, add _p suffix.
dbatyai
force-pushed
the
array_prototype_sort
branch
from
761c079 to
7fe0d39
Compare
|
I've updated the patch. |
|
Looks good to me. |
| { | ||
| /* Casting len to ecma_length_t may overflow, but since ecma_length_t is still at lest 16 bits long, | ||
| with an array of that size, we would run out of memory way before this happens. */ | ||
| JERRY_ASSERT ((ecma_length_t) len == len); |
There was a problem hiding this comment.
Please, add FIXME to the comment.
Seems that we should change the ecma_op_create_array_object interface to take another type for length argument.
There was a problem hiding this comment.
Could you, please, raise an issue about this?
There was a problem hiding this comment.
Added FIXME, and opened an issue about it: #133
dbatyai
force-pushed
the
array_prototype_sort
branch
from
7fe0d39 to
9a88ef0
Compare
|
@dbatyai great! |
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan szledan.u-szeged@partner.samsung.com
dbatyai
force-pushed
the
array_prototype_sort
branch
from
9a88ef0 to
0fc82e2
Compare
|
merged: 6b8e34a |
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
JerryScript-DCO-1.0-Signed-off-by: Szilard Ledan szledan.u-szeged@partner.samsung.com