Implemented jerry_api_create_error() #76
Conversation
|
For #35 |
|
|
||
| ecma_standard_error_t standard_error_type = ECMA_ERROR_COMMON; | ||
|
|
||
| switch (error_type) |
There was a problem hiding this comment.
Do we really need additional level of abstraction for that? Why don't we simply use ECMA_ERROR_COMMON, ECMA_ERROR_EVAL etc? As for me, its better to extend ecma_standard_error_t enum if needed and use it across the API.
There was a problem hiding this comment.
That was questionable for me too, Then let's make it use only ecma_standart_error_t.
There was a problem hiding this comment.
What do you think about naming? should we change the name of enum entry like ECMA_ERROR_COMMON to JERRY_ERROR_COMMON ?
egavrin
added
minor
api
|
@egavrin, Updated PR so that it uses |
| * | ||
| * See also: 15.11.1, 15.11.6 | ||
| */ | ||
| typedef enum |
There was a problem hiding this comment.
There is no need to move this enum out of ecma-exceptions, since all related functionality is defined here. So, just reference ecma-exceptions.h in jerry.cpp.
There was a problem hiding this comment.
Would clients for libjerry be supposed referring only jerry-api.h? The api user need to know what kind of error they want to make. If the definition is in ecma-exception.h, user program of libjerry should also need that file to include.
There was a problem hiding this comment.
Ah...I got your concern. Let's go back to the issue discussion #35.
JerryScript-DCO-1.0-Signed-off-by: Ilyong Cho ily.cho@samsung.com
|
@egavrin OK, rolled back to the first PR rebased on top of master. |
|
@ILyoan |
jerry_api_create_error()