Fix undefined initialValue handling in Array.prototype.reduce and reduceRight function #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkristof
added
bug
| ecma_value_t accumulator = ecma_make_simple_value (ECMA_SIMPLE_VALUE_UNDEFINED); | ||
|
|
||
| /* 5. */ | ||
| if (len_number == ECMA_NUMBER_ZERO && ecma_is_value_undefined (arg2)) | ||
| if (len_number == ECMA_NUMBER_ZERO && ecma_is_value_undefined (initialValue)) |
There was a problem hiding this comment.
Please, avoid usage of CamelCase. initial_value
There was a problem hiding this comment.
Sorry, I missed that.
kkristof
force-pushed
the
fix_array_reduce
branch
from
a106ba2 to
7510a88
Compare
|
I have updated the PR |
|
Good to me. |
|
lgtm |
…uceRight function. JerryScript-DCO-1.0-Signed-off-by: Kristof Kosztyo kkosztyo.u-szeged@partner.samsung.com
kkristof
force-pushed
the
fix_array_reduce
branch
from
7510a88 to
9ffa6a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Kristof Kosztyo kkosztyo.u-szeged@partner.samsung.com