Skip to content

Parse integer numbers from back to front. #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2015

Conversation

dbatyai
Copy link
Member

@dbatyai dbatyai commented Aug 13, 2015

Parsing from back to front prevents precision loss in case of large numbers.
Fixes: S15.1.2.2_A7.2_T3.js

@dbatyai dbatyai added bug Undesired behaviour parser Related to the JavaScript parser labels Aug 13, 2015
@kkristof
Copy link
Contributor

Looks good to me.

@zherczeg
Copy link
Member

LGTM

@egavrin
Copy link
Contributor

egavrin commented Aug 13, 2015

Please, rename N.arithmetics-bignums.js to arithmetics-bignums.js - it's important, since tests with N. are ignored or not supported.

@dbatyai
Copy link
Member Author

dbatyai commented Aug 14, 2015

@egavrin, done.

@tilmannOSG
Copy link

@egavrin Can Daniel merge the patch?

@egavrin
Copy link
Contributor

egavrin commented Sep 8, 2015

yes

@egavrin egavrin assigned dbatyai and unassigned egavrin Sep 8, 2015
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
@dbatyai dbatyai merged commit 91f0c9d into jerryscript-project:master Sep 16, 2015
@dbatyai dbatyai deleted the integer-parsing branch March 1, 2016 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour parser Related to the JavaScript parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants