Fix RegExp literal parsing #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbatyai
added
bug
| || prev_non_lf_token.type == TOK_SMALL_INT | ||
| || prev_non_lf_token.type == TOK_NUMBER | ||
| || prev_non_lf_token.type == TOK_STRING | ||
| || prev_non_lf_token.type == TOK_REGEXP)) |
There was a problem hiding this comment.
TOK_CLOSE_PAREN and TOK_CLOSE_BRACE could precede regular expression, for example:
if (true) /abc/.exec("abc");
if (true) {} /abc/.exec("abc");
This case is harder to support, possibly, we could implement it in another patch.
There was a problem hiding this comment.
Another case:
var a
/abc/.exec("abc");
Could you, please, create an issue for the mentioned tests?
There was a problem hiding this comment.
Issue can be found here: #563
dbatyai
force-pushed
the
regexp-literal-parsing
branch
from
c3acb74 to
6fc3e43
Compare
|
@sand1k, I've updated the patch, it should work correctly now. Please check. |
|
LGTM. |
|
LGTM |
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
dbatyai
force-pushed
the
regexp-literal-parsing
branch
from
6fc3e43 to
4ee30cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.