Skip to content

Conversation

@dbatyai
Copy link
Member

@dbatyai dbatyai commented Aug 10, 2015

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com

@dbatyai dbatyai added bug Undesired behaviour ecma builtins Related to ECMA built-in routines labels Aug 10, 2015
@dbatyai dbatyai added this to the ECMA builtins milestone Aug 10, 2015
@dbatyai dbatyai added the parser Related to the JavaScript parser label Aug 11, 2015
@egavrin egavrin assigned sand1k and unassigned egavrin Aug 11, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, change this call to lit_utf8_iterator_incr (iter_p), the same effect, but simpler.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@dbatyai dbatyai force-pushed the regexp-control-excapes branch from b1f0579 to c4c9b7f Compare August 11, 2015 16:18
@sand1k
Copy link
Contributor

sand1k commented Aug 12, 2015

LGTM.

@sand1k sand1k assigned dbatyai and unassigned sand1k Aug 12, 2015
@zherczeg
Copy link
Member

LGTM

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
@dbatyai dbatyai force-pushed the regexp-control-excapes branch from c4c9b7f to d2ac7c3 Compare August 12, 2015 09:41
@dbatyai dbatyai merged commit d2ac7c3 into jerryscript-project:master Aug 12, 2015
@dbatyai dbatyai deleted the regexp-control-excapes branch August 12, 2015 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Undesired behaviour ecma builtins Related to ECMA built-in routines parser Related to the JavaScript parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants