Use ecma-collection in JSON. #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkristof
added
enhancement
|
|
||
| return false; | ||
| } /* list_has_element */ | ||
| ecma_collection_iterator_t iterator; |
There was a problem hiding this comment.
Maybe, the function should be named ecma_has_object_value_in_collection.
rtakacs
force-pushed
the
json_collection
branch
from
aafed1a to
653c815
Compare
|
I've updated the pull request. |
| ecma_string_t *gap_str_p; | ||
|
|
||
| /** The replacer function. */ | ||
| ecma_object_t *replacer_function_p; | ||
| } stringify_context_t; |
There was a problem hiding this comment.
Could you, please, also add ecma_json_ or ecma_ prefix to the structure name?
|
Looks good to me |
rtakacs
force-pushed
the
json_collection
branch
from
653c815 to
bf94ded
Compare
The simple list data structure has been replaced with ecma-collection in the JSON object. JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.u-szeged@partner.samsung.com
rtakacs
force-pushed
the
json_collection
branch
from
bf94ded to
ff580ca
Compare
|
lgtm |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simple list data structure has replaced with ecma-collection in the JSON object.