Fix assertion 'bytes_copied > 0 || !string_len' in JSON.stringify() #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Solution for #406 |
rtakacs
force-pushed
the
json_stringify_unicode
branch
from
9582c1c to
1419e37
Compare
egavrin
added
bug
| @@ -1117,11 +1117,11 @@ ecma_builtin_json_stringify (ecma_value_t this_arg __attr_unused___, /**< 'this' | |||
| { | |||
| ecma_length_t string_len = ecma_string_get_length (space_str_p); | |||
There was a problem hiding this comment.
Are you sure this is length not size?
rtakacs
force-pushed
the
json_stringify_unicode
branch
from
1419e37 to
d08c5ec
Compare
|
LGTM |
|
|
||
| context_p.gap_str_p = ecma_new_ecma_string_from_utf8 ((lit_utf8_byte_t *) space_buff, 10); | ||
| context_p.gap_str_p = ecma_new_ecma_string_from_utf8 ((lit_utf8_byte_t *) space_buff, space_buff_size); |
There was a problem hiding this comment.
Do we really need space_buff?
As I see, we can just call ecma_new_ecma_string_from_utf8 (string_buff, space_buff_size).
There was a problem hiding this comment.
hm... You are right, we don't need space_buff.
Updating.
rtakacs
force-pushed
the
json_stringify_unicode
branch
from
d08c5ec to
fe67b75
Compare
|
|
||
| MEM_FINALIZE_LOCAL_ARRAY (space_buff); | ||
| MEM_FINALIZE_LOCAL_ARRAY (zt_string_buff); | ||
| MEM_FINALIZE_LOCAL_ARRAY (string_buff); |
There was a problem hiding this comment.
To extract a substirng, it is better to use:
context_p.gap_str_p = ecma_string_substr (space_str_p, 0, 10).
Sorry, noticed just now, that this fragment could be simplified so much.
rtakacs
force-pushed
the
json_stringify_unicode
branch
2 times, most recently
from
a83cd9d to
5f296ba
Compare
|
LGTM. |
rtakacs
force-pushed
the
json_stringify_unicode
branch
2 times, most recently
from
b79e960 to
4ac18b8
Compare
JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.u-szeged@partner.samsung.com
rtakacs
force-pushed
the
json_stringify_unicode
branch
from
4ac18b8 to
5888401
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified some places to support unicode characters.
Also renamed some variables to be more clearer.