Handle Unicode characters in parseFloat() #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbatyai
added
bug
| /* Check if string is equal to "Infinity". */ | ||
| while (!lit_utf8_iterator_is_eos (&iter) | ||
| && (lit_utf8_iterator_read_next (&iter) == lit_utf8_iterator_read_next (&infinity_iter))) | ||
| { |
There was a problem hiding this comment.
I think its better to use lit_compare_utf8_string_and_magic_string to compare with "Infinity", the code would be more compact:
if (lit_compare_utf8_string_and_magic_string (iter.buf_p + start.offset,
iter.buf_size - start.offset,
LIT_MAGIC_STRING_INFINITY_UL))
{
...
}
There was a problem hiding this comment.
We can't use lit_compare_utf8_string_and_magic_string here, because we have to check if a prefix of the string contains "Infinity". For example, "Infinityfoo" should also be valid.
dbatyai
force-pushed
the
global_parsefloat_unicode
branch
from
dab789d to
759ac46
Compare
|
Thanks for the tests, |
| } | ||
| else | ||
| { | ||
| lit_utf8_iterator_read_prev (&iter); |
There was a problem hiding this comment.
Could you, please, replace lit_utf8_iterato_read_prev with lit_utf8_iterator_decr when you don't use return value?
dbatyai
force-pushed
the
global_parsefloat_unicode
branch
2 times, most recently
from
6712f54 to
e898950
Compare
|
LGTM. |
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
dbatyai
force-pushed
the
global_parsefloat_unicode
branch
from
e898950 to
c17197d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com