Implement Object.prototype.isPrototypeOf #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galpeter
changed the title
galpeter
force-pushed
the
object_prototype_isprototypeof
branch
from
0718623 to
ad4bab7
Compare
21 tasks
| ecma_object_t *v_obj_p = ecma_get_object_from_value (v_obj_value); | ||
|
|
||
| do | ||
| { |
There was a problem hiding this comment.
Just a general comment, could you also add comments to the lines corresponding to sub-bullets from the ECMA paragraphs, like /* 3.a ... */.
galpeter
force-pushed
the
object_prototype_isprototypeof
branch
from
ad4bab7 to
be103c4
Compare
|
@egavrin, |
|
Fine, |
galpeter
force-pushed
the
object_prototype_isprototypeof
branch
from
be103c4 to
7d70304
Compare
25 tasks
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com