Make parseInt unicode tolerant #467
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galpeter
added
bug
| { | ||
| if ((utf8_string_buff[i]) >= LIT_CHAR_LOWERCASE_A && utf8_string_buff[i] <= LIT_CHAR_LOWERCASE_Z) | ||
| ecma_char_t current_char = lit_utf8_iterator_read_next (&iter); | ||
| ecma_number_t current_number; |
There was a problem hiding this comment.
I think we should use an integer type here instead of an ecma_number_t.
There was a problem hiding this comment.
good point, will fix it in the update.
|
LGTM |
| { | ||
| start++; | ||
| start = lit_utf8_iterator_get_pos (&iter); | ||
| current = lit_utf8_iterator_read_next (&iter); |
There was a problem hiding this comment.
Shouldn't we check for eos before doing this?
JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com
galpeter
force-pushed
the
unicodify_parseint
branch
from
b7dddd1 to
b5e4dc5
Compare
|
PR updated. |
| { | ||
| start += 2; | ||
| ecma_char_t next = lit_utf8_iterator_peek_next (&iter); |
There was a problem hiding this comment.
There should probably be an eos check here as well.
There was a problem hiding this comment.
In this case it is not needed, as the offset check in the if statement above already checked that there are at least two characters, so we are not at the end of the string yet.
|
lgtm |
|
LGTM. |
|
|
|
Landed: 3fbe543 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405
JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com