Fix push() and unshift() in case result length is larger than UINT_MAX #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbatyai
added
bug
| if (ecma_object_get_class_name (object) == LIT_MAGIC_STRING_ARRAY_UL | ||
| && unlikely (length > (uint32_t)(-1))) /* Check if length greater than UINT_MAX */ | ||
| { | ||
| ret_value = ecma_make_throw_obj_completion_value (ecma_new_standard_error (ECMA_ERROR_RANGE)); |
There was a problem hiding this comment.
@dbatyai, the error should be raised in ecma_op_array_object_define_own_property. Is there any case, where it isn't raised?
…ger than UINT_MAX JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
dbatyai
force-pushed
the
array_push_max_length
branch
from
8f8bda2 to
e647b4c
Compare
|
@ruben-ayrapetyan, I've updated the patch. The error does get raised correctly in |
| index++, n++) | ||
| { | ||
| /* 5.a */ | ||
| ecma_value_t e_value = argument_list_p[index]; | ||
|
|
||
| /* 5.b */ | ||
| ecma_string_t *n_str_p = ecma_new_ecma_string_from_uint32 (n); | ||
| ecma_string_t *n_str_p = ecma_new_ecma_string_from_number (n); |
There was a problem hiding this comment.
It is better to use ecma_new_ecma_string_from_uint32 instead of ecma_new_ecma_string_from_number, as it reduces memory usage.
There was a problem hiding this comment.
We can't use ecma_new_ecma_string_from_uint32 here, because the index can go above 2^32.
There was a problem hiding this comment.
I see. Thanks for explanation.
|
Looks good to me |
|
Looks good to me. |
|
Landed: fec5933 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com