Use [[DefineOwnProperty]] in Array builtins where necessary. #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbatyai
added
bug
| ecma_free_completion_value (put_comp_value); | ||
|
|
||
| /* 10.c.ii */ | ||
| ecma_property_descriptor_t prop_desc = ecma_make_empty_property_descriptor (); |
There was a problem hiding this comment.
I think we should introduce a helper function to eliminate repetitive code.
dbatyai
force-pushed
the
array_use_define_own_prop
branch
2 times, most recently
from
a5e5fe8 to
e2a4498
Compare
|
good to me |
| * Returned value must be freed with ecma_free_completion_value. | ||
| */ | ||
| ecma_completion_value_t | ||
| ecma_builtin_helper_def_prop (ecma_object_t *obj, /**< object */ |
dbatyai
force-pushed
the
array_use_define_own_prop
branch
from
e2a4498 to
fd09ada
Compare
| @@ -35,6 +35,13 @@ extern ecma_completion_value_t ecma_builtin_helper_array_concat_value (ecma_obje | |||
| ecma_value_t); | |||
| extern uint32_t ecma_builtin_helper_array_index_normalize (ecma_number_t index, uint32_t length); | |||
| extern uint32_t ecma_builtin_helper_string_index_normalize (ecma_number_t index, uint32_t length); | |||
| extern ecma_completion_value_t ecma_builtin_helper_def_prop (ecma_object_t *obj, | |||
dbatyai
force-pushed
the
array_use_define_own_prop
branch
from
fd09ada to
b154597
Compare
|
@galpeter, fixed. |
|
lgtm |
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
dbatyai
force-pushed
the
array_use_define_own_prop
branch
from
b154597 to
1193de8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[[Put]] fails to create the property when we have inherited properties from Array.prototype.
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com