Fix Array index normalize helper when index is large. #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbatyai
added
bug
| norm_index = uint_index > length ? 0 : length - uint_index; | ||
| } | ||
| else | ||
| { | ||
| norm_index = (uint32_t) int_index; | ||
| norm_index = ecma_number_to_uint32 (index); |
There was a problem hiding this comment.
@dbatyai, 15.4.4.10.5 uses ToInteger that doesn't perform modulo 2^32 operation during conversion. Maybe, this can lead to incorrect conversion in the cases, if index is more than 2^32.
There was a problem hiding this comment.
@ruben-ayrapetyan, fixed and added test case.
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
dbatyai
force-pushed
the
array_index_normalize_helper_fix
branch
from
9da491d to
796ae99
Compare
|
Looks good to me |
|
Looks good to me. |
|
Please rebase to master and I'll merge |
|
Landed: 6567651 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com