Skip to content

Implement Date.prototype.toJSON() #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2015
Merged

Implement Date.prototype.toJSON() #455

merged 1 commit into from
Jul 24, 2015

Conversation

@rtakacs
Copy link
Contributor

@rtakacs rtakacs commented Jul 23, 2015

No description provided.

@dbatyai dbatyai added ecma builtins Related to ECMA built-in routines development Feature implementation labels Jul 23, 2015
@dbatyai dbatyai added this to the ECMA builtins milestone Jul 23, 2015
dbatyai
dbatyai reviewed Jul 23, 2015
View reviewed changes
jerry-core/ecma/builtin-objects/ecma-builtin-date-prototype.cpp Outdated
Copy link
Member

@dbatyai dbatyai Jul 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to add unused attribute here?

Copy link
Contributor Author

@rtakacs rtakacs Jul 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops. Fixed.

@galpeter
Copy link
Contributor

galpeter commented Jul 23, 2015

looks good to me

ruben-ayrapetyan
ruben-ayrapetyan reviewed Jul 23, 2015
View reviewed changes
jerry-core/ecma/builtin-objects/ecma-builtin-date-prototype.cpp Outdated
Copy link

@ruben-ayrapetyan ruben-ayrapetyan Jul 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add semicolons at end of the lines.

Copy link
Contributor Author

@rtakacs rtakacs Jul 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@egavrin
Copy link
Contributor

egavrin commented Jul 24, 2015

Good to me

@dbatyai
Copy link
Member

dbatyai commented Jul 24, 2015

lgtm

@ruben-ayrapetyan
Copy link

ruben-ayrapetyan commented Jul 24, 2015

Looks good to me

Implement Date.prototype.toJSON()
ed16f09 
JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.u-szeged@partner.samsung.com
@dbatyai dbatyai merged commit ed16f09 into jerryscript-project:master Jul 24, 2015
@galpeter galpeter mentioned this pull request Jul 24, 2015
Closed
50 tasks
@zherczeg zherczeg mentioned this pull request Jul 20, 2016
Closed
@rtakacs rtakacs deleted the date_tojson branch January 18, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

development Feature implementation ecma builtins Related to ECMA built-in routines

Projects

None yet

Milestone

ECMA builtins

Development

Successfully merging this pull request may close these issues.

5 participants

@rtakacs @galpeter @egavrin @dbatyai @ruben-ayrapetyan