Implement Date.prototype.toJSON() #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbatyai
added
ecma builtins
| @@ -1097,7 +1098,7 @@ ecma_builtin_date_prototype_to_utc_string (ecma_value_t this_arg) /**< this argu | |||
| * Returned value must be freed with ecma_free_completion_value. | |||
| */ | |||
| static ecma_completion_value_t | |||
| ecma_builtin_date_prototype_to_iso_string (ecma_value_t this_arg) /**< this argument */ | |||
| ecma_builtin_date_prototype_to_iso_string (ecma_value_t this_arg __attr_unused___) /**< this argument */ | |||
There was a problem hiding this comment.
Why do we need to add unused attribute here?
|
looks good to me |
| } | ||
|
|
||
| ECMA_FINALIZE (tv) | ||
| ECMA_FINALIZE (obj) |
There was a problem hiding this comment.
Please, add semicolons at end of the lines.
|
Good to me |
|
lgtm |
|
Looks good to me |
JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.u-szeged@partner.samsung.com
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.