Introduce jerry_port_track_promise_rejection #4451
Conversation
rerobika
added
the
jerry-port
rerobika
force-pushed
the
port_promise_rejection_tracker
branch
from
94cdf15 to
59483cd
Compare
rerobika
force-pushed
the
port_promise_rejection_tracker
branch
from
59483cd to
a39ad7b
Compare
rerobika
changed the title
rerobika
force-pushed
the
port_promise_rejection_tracker
branch
2 times, most recently
from
d8f0141 to
7a265f4
Compare
| * @param promise rejected promise | ||
| * @param operation HostPromiseRejectionTracker operation | ||
| */ | ||
| void jerry_port_track_promise_rejection (const jerry_value_t promise, |
There was a problem hiding this comment.
I was also considering suggesting yet another name change, to have the new function named jerry_port_promise_rejection_tracker. That would make the new typedef and the new function names aligned, as well as the name used by the spec. However, existing port API function names usually start with a verb (get this, set that, sleep, print, log, etc. -- the only exception being fatal). So, I'm not sure about this. But we should agree upon a good name so that it doesn't need to be changed, at least in the near future.
There was a problem hiding this comment.
I'd keep this jerry_port_track_promise_rejection for the due to the starting verb convention with the other API functions.
jerry_port_promise_rejection_tracker would be suitable if we would rename jerry_port_log to jerry_port_logger and so on. So I'd leave as it for now.
rerobika
force-pushed
the
port_promise_rejection_tracker
branch
from
7a265f4 to
b39ac3d
Compare
|
@akosthekiss Thanks for the review, I've updated the PR. |
This patch resolves jerryscript-project#2931. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
rerobika
force-pushed
the
port_promise_rejection_tracker
branch
from
b39ac3d to
7bce57c
Compare
This patch resolves #2931.
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu