Fix parseInt when passing empty string #430
Conversation
galpeter
added
bug
|
Related issue: #428 |
| @@ -112,7 +112,7 @@ ecma_builtin_global_object_parse_int (ecma_value_t this_arg __attr_unused___, /* | |||
| ecma_string_t *number_str_p = ecma_get_string_from_value (string_var); | |||
| lit_utf8_size_t str_size = ecma_string_get_size (number_str_p); | |||
|
|
|||
| MEM_DEFINE_LOCAL_ARRAY (utf8_string_buff, str_size, lit_utf8_byte_t); | |||
| MEM_DEFINE_LOCAL_ARRAY (utf8_string_buff, str_size + 1, lit_utf8_byte_t); | |||
There was a problem hiding this comment.
@ruben-ayrapetyan, yeah that's why I was thinking initially, thus I have this: galpeter@f3081a0 would that be ok?
There was a problem hiding this comment.
@galpeter, yes, I think this would be ok.
|
@ruben-ayrapetyan, I've updated the PR, and now it uses |
|
Looks good to me |
|
LGTM |
galpeter
force-pushed
the
fix_428_b
branch
2 times, most recently
from
0ad90c5 to
96d315a
Compare
| { | ||
| /* Not a valid number char, set value to radix so it fails to pass as a valid character. */ | ||
| utf8_string_buff[i] = (lit_utf8_byte_t) rad; | ||
| if ((utf8_string_buff[i]) >= 'a' && utf8_string_buff[i] <= 'z') |
There was a problem hiding this comment.
Literals has constants (defines) for these characters. Please use them.
There was a problem hiding this comment.
@zherczeg, I don't think it is wise to replace the with the equivalent LIT_ define, as those are ecma_char_t types (unit16_t), but here we use lit_utf8_byte_t (unit_8_t). Should I really replace the constants?
There was a problem hiding this comment.
@zherczeg, I've got a follow up fix, which rewrites the parseInt to use the lit_iterators to support unicode characters and there the constants are fixed. So should I also include the constants in this PR?
|
Please fix the above, and LGTM after that. |
|
@zherczeg, I've replaced the character constants with the |
Before allocating buffer for the string first we check that the length of it is greater then 0. If not then the result is a NaN. JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com
|
Landed: ee8d650 |
Corrected the base buffer size for the string.
JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com