Fix leak in Array.prototype.indexOf() #427
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbatyai
added
bug
dbatyai
force-pushed
the
array_indexof_leak
branch
from
b632674 to
3d3f467
Compare
| @@ -951,6 +950,9 @@ ecma_builtin_array_prototype_object_index_of (ecma_value_t this_arg, /**< this a | |||
| /* 5. */ | |||
| ECMA_OP_TO_NUMBER_TRY_CATCH (arg_from_idx, arg2, ret_value); | |||
|
|
|||
| ecma_number_t *num_p = ecma_alloc_number (); | |||
| *num_p = ecma_int32_to_number (-1); | |||
There was a problem hiding this comment.
The lines could be moved to if block at line 991, and here we can define variable of ecma_number_t, not pointer.
In the case, call to ecma_dealloc_number at line 995 could be removed.
dbatyai
force-pushed
the
array_indexof_leak
branch
from
3d3f467 to
cc32d50
Compare
|
Looks good to me |
|
+1 LGTM |
…o primitive value. JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
dbatyai
force-pushed
the
array_indexof_leak
branch
from
cc32d50 to
337c7cf
Compare
|
Merged 27161d3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leak occurs when
fromIndexcan't coerce to primitive value.JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com