Fix Array.prototype.concat() when 'this' is not an array. #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbatyai
added
bug
There was a problem hiding this comment.
@dbatyai, could you, please, add comments with steps from specification that correspond to the operations?
dbatyai
force-pushed
the
array_concat_obj_this
branch
from
c8d2fdb to
756494b
Compare
There was a problem hiding this comment.
As is_throw argument of ecma_op_object_put is false, exceptions can't be thrown and only possible return values in the case are "simple true" or "simple false".
So, we can replace this with corresponding assertion and remove ecma_free_completion_value call.
dbatyai
force-pushed
the
array_concat_obj_this
branch
2 times, most recently
from
f0500cb to
a407d31
Compare
Member
Author
|
@ruben-ayrapetyan, I've updated the patch. |
|
@dbatyai, thank you for update. |
|
After fixing #415 (comment) the changes would look good to me |
dbatyai
force-pushed
the
array_concat_obj_this
branch
from
a407d31 to
8d7789f
Compare
|
Looks good to me |
Contributor
|
looks good to me |
dbatyai
force-pushed
the
array_concat_obj_this
branch
from
8d7789f to
046833c
Compare
Contributor
|
Could you please rebase it to master - I'm getting conflicts at merging. |
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
dbatyai
force-pushed
the
array_concat_obj_this
branch
from
046833c to
9513808
Compare
Member
Author
|
@egavrin, rebased to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com