Skip to content

Fix several function name related issues#3848

Merged
dbatyai merged 1 commit into
jerryscript-project:masterfrom
rerobika:fix_function_name
Jun 4, 2020
Merged

Fix several function name related issues#3848
dbatyai merged 1 commit into
jerryscript-project:masterfrom
rerobika:fix_function_name

Conversation

@rerobika

@rerobika rerobika commented Jun 4, 2020

Copy link
Copy Markdown
Member
  • For non-computed name script functions only identifier/string literal should be set as name
  • Implicit class constructor names with non string function name should be ToString-ed

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu

 - For non-computed name srcipt functions only identifier/string literal should be set as name
 - Implicit class constructor names with non string function name should be ToString-ed

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
@rerobika rerobika added the bug Undesired behaviour label Jun 4, 2020
@rerobika

rerobika commented Jun 4, 2020

Copy link
Copy Markdown
Member Author

Note: The issues were found by Fuzzinator with grammarinator.

@zherczeg zherczeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit c09c2c5 into jerryscript-project:master Jun 4, 2020
@rerobika rerobika deleted the fix_function_name branch June 16, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Undesired behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants