Implement toLowerCase and toUpperCase built-in functions. #365
Conversation
|
Please add reference to #323 |
egavrin
added
ecma builtins
|
Good to me. |
|
What do you mean by adding a reference? Adding a comment in the function? E.g: |
| * Utility functions for uppercasing / lowercasing | ||
| */ | ||
|
|
||
| #define MAXIMUM_OTHERCASE_LENGTH (3) |
There was a problem hiding this comment.
@zherczeg, could you, please, add LIT_ prefix and add describing comment for the definition?
zherczeg
force-pushed
the
to-lower-upper-case-dev
branch
from
fd0d85b to
9636728
Compare
|
@zherczeg I mean commit message: |
|
fyi |
| * Utility functions for uppercasing / lowercasing | ||
| */ | ||
|
|
||
| #define LIT_MAXIMUM_OTHERCASE_LENGTH (3) |
There was a problem hiding this comment.
@zherczeg, what is the meaning of the value?
zherczeg
force-pushed
the
to-lower-upper-case-dev
branch
from
9636728 to
6b8e819
Compare
|
Thank you for the comments. I hope fixed all of them. |
| /** | ||
| * Returns the lowercase character sequence of an ecma character. | ||
| * | ||
| * Note: output_buffer_p must be able to hold at least LIT_MAXIMUM_OTHER_CASE_LENGTH characters. |
There was a problem hiding this comment.
@zherczeg, could you, please, add arguments like buffer_size to the function, and check the condition with JERRY_ASSERT?
|
After adding |
zherczeg
force-pushed
the
to-lower-upper-case-dev
branch
from
6b8e819 to
0a6ba71
Compare
|
@zherczeg, thank you for update. By the way, |
Related issue: #323 JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg@inf.u-szeged.hu
zherczeg
force-pushed
the
to-lower-upper-case-dev
branch
from
0a6ba71 to
b130484
Compare
|
Looks good to me |
|
|
|
Landed in 69655f4 |
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg@inf.u-szeged.hu