Fix Number.prototype.toFixed if argument is outside int32 range #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good to me |
| @@ -251,6 +248,9 @@ ecma_builtin_number_prototype_object_to_fixed (ecma_value_t this_arg, /**< this | |||
| int32_t num_digits = 0; | |||
| int32_t exponent = 1; | |||
|
|
|||
| /* 1. */ | |||
| int32_t frac_digits = ecma_number_to_int32 (arg_num); | |||
|
|
|||
There was a problem hiding this comment.
number_to_int32 returns 0 for -0.9? I don't know, just asking.
There was a problem hiding this comment.
It does. I'll add a test case for this.
dbatyai
force-pushed
the
number_tofixed_infinity_fix
branch
from
4133768 to
95be3df
Compare
|
lgtm |
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
dbatyai
force-pushed
the
number_tofixed_infinity_fix
branch
from
95be3df to
47cd42e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com