Fix receiving of byte-code instructions from serializer #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruben-ayrapetyan
added
bug
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-203
branch
2 times, most recently
from
7f4ad37 to
bc0287c
Compare
| opcode_t | ||
| serializer_get_opcode (opcode_counter_t oc) | ||
| serializer_get_opcode (const opcode_t* opcodes_p, /**< pointer to byte-code array (or NULL, |
|
Good to me, after fixing. |
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-203
branch
from
bc0287c to
f6f2c1f
Compare
|
Pull request is updated:
|
| @@ -179,7 +179,10 @@ dump_asm (opcode_counter_t oc, opcode_t opcode) | |||
| } | |||
|
|
|||
| void | |||
| pp_op_meta (opcode_counter_t oc, op_meta opm, bool rewrite) | |||
| pp_op_meta (const opcode_t* opcodes_p, | |||
There was a problem hiding this comment.
Incorrect alignment of the *.
|
aside from the minor style issue it looks good to me. |
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-203
branch
from
f6f2c1f to
eb28b09
Compare
|
Pull request is updated:
|
|
|
Related issue: #203 JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan r.ayrapetyan@samsung.com
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-203
branch
from
eb28b09 to
ab2abfa
Compare
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #203