Skip to content

Implement Number.prototype.toExponential() #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Implement Number.prototype.toExponential() #224

wants to merge 1 commit into from

Conversation

@dbatyai
Copy link
Member

@dbatyai dbatyai commented Jun 22, 2015

JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com

@dbatyai dbatyai added ecma builtins Related to ECMA built-in routines development Feature implementation labels Jun 22, 2015
@dbatyai dbatyai added this to the ECMA builtins milestone Jun 22, 2015
ruben-ayrapetyan
ruben-ayrapetyan reviewed Jun 22, 2015
View reviewed changes
jerry-core/ecma/builtin-objects/ecma-builtin-number-prototype.cpp Outdated
Copy link

@ruben-ayrapetyan ruben-ayrapetyan Jun 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ToNumber returns NaN for undefined, and ToInt32 returns zero for NaN.

@dbatyai dbatyai assigned ruben-ayrapetyan and unassigned dbatyai Jun 24, 2015
@galpeter galpeter mentioned this pull request Jun 25, 2015
Closed
16 tasks
kkristof
kkristof reviewed Jun 25, 2015
View reviewed changes
jerry-core/ecma/builtin-objects/ecma-builtin-number-prototype.cpp Outdated
Copy link
Contributor

@kkristof kkristof Jun 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong placed *

@dbatyai
Implement Number.prototype.toExponential()
dd0ac26 
JerryScript-DCO-1.0-Signed-off-by: Dániel Bátyai dbatyai.u-szeged@partner.samsung.com
@dbatyai
Copy link
Member Author

dbatyai commented Jun 26, 2015

I've updated the PR, please take a look.

@kkristof
Copy link
Contributor

kkristof commented Jun 29, 2015

lgtm

@dbatyai
Copy link
Member Author

dbatyai commented Jun 29, 2015

@egavrin, @ruben-ayrapetyan , any other comments?

@ruben-ayrapetyan
Copy link

ruben-ayrapetyan commented Jun 29, 2015

@dbatyai, I've got no other comments.

@egavrin
Copy link
Contributor

egavrin commented Jun 30, 2015

Good to me

@egavrin egavrin assigned dbatyai and unassigned egavrin Jun 30, 2015
@dbatyai
Copy link
Member Author

dbatyai commented Jul 1, 2015

merged: 53cbb55

@dbatyai dbatyai closed this Jul 1, 2015
@huxinx huxinx mentioned this pull request Jan 8, 2016
Closed
@zherczeg zherczeg mentioned this pull request Jul 20, 2016
Closed
This was referenced May 17, 2020
Closed
Closed
@kvenux kvenux mentioned this pull request Oct 20, 2020
Closed
This was referenced Oct 20, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dbatyai dbatyai

Labels

development Feature implementation ecma builtins Related to ECMA built-in routines

Projects

None yet

Milestone

ECMA builtins

Development

Successfully merging this pull request may close these issues.

5 participants

@dbatyai @kkristof @ruben-ayrapetyan @egavrin @zherczeg