Remove invalid assertion in ecma_builtin_global_object_eval
#220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruben-ayrapetyan
added
bug
| @@ -60,8 +60,6 @@ ecma_builtin_global_object_eval (ecma_value_t this_arg, /**< this argument */ | |||
| ecma_completion_value_t ret_value = ecma_make_empty_completion_value (); | |||
|
|
|||
| bool is_direct_eval = vm_is_direct_eval_form_call (); | |||
| JERRY_ASSERT (!(is_direct_eval | |||
There was a problem hiding this comment.
ecma_value_t this_arg should be marked as unused.
There was a problem hiding this comment.
@egavrin, thanks.
I've updated pull request.
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-212
branch
from
75e48c1 to
7081562
Compare
|
Good to me |
|
lgtm |
|
|
The removed assertion checked that `this` argument can't be equal to `undefined` in direct call to eval. Actually, `this` can be not equal to `undefined` in case direct call to eval is performed from `with` block. Related issue: #212 JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan r.ayrapetyan@samsung.com
ruben-ayrapetyan
force-pushed
the
Ruben-fix-issue-212
branch
from
7081562 to
6118116
Compare
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed assertion checked that
thisargument can't be equal toundefinedin direct call to eval.Actually,
thiscan be not equal toundefinedin case direct call to eval is performed fromwithblock.Related issue: #212