Implement Object.seal and Object.isSealed function #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
|
|
||
| if (prop_p->type == ECMA_PROPERTY_NAMEDDATA) | ||
| { | ||
| prop_desc.value = ecma_get_named_data_property_value (prop_p); | ||
| prop_desc.is_value_defined = true; | ||
| prop_desc.is_value_defined = ecma_is_value_empty (prop_desc.value) ? true : false; |
There was a problem hiding this comment.
Could this value be empty?
There was a problem hiding this comment.
Hmm, this was supposed to fix an assertion but I definitely swapped the logical value so this is just an ugly and wrong hack.
egavrin
added
ecma builtins
|
Hi, I have updated the branch. |
| property_p->u.named_data_property.name_p); | ||
| } | ||
| else | ||
| if (property_p->type == ECMA_PROPERTY_NAMEDACCESSOR) |
There was a problem hiding this comment.
else if should be on one line.
|
lgtm, but it seems this needs a rebase |
|
Hi, I have rebased for the current master. |
| continue; | ||
| } | ||
|
|
||
| // 2.b |
There was a problem hiding this comment.
Could you, please, add an assertion that the property's type is one of named property types?
|
Hi, I have updated and rebased the patch. |
|
Looks good to me. |
ruben-ayrapetyan
assigned galpeter and egavrin and unassigned ruben-ayrapetyan and galpeter
|
lgtm |
|
|
JerryScript-DCO-1.0-Signed-off-by: Kristof Kosztyo kkosztyo.u-szeged@partner.samsung.com
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Kristof Kosztyo kkosztyo.u-szeged@partner.samsung.com