Add abort () to jerry-libc
#141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ruben-ayrapetyan mentioned in #134 that |
|
Looks good to me |
| @@ -48,18 +48,35 @@ LIBC_UNREACHABLE_STUB_FOR (int raise (int sig_no __attr_unused___)) | |||
| #define LIBC_EXIT_ON_ERROR(syscall_ret_val) \ | |||
| if ((syscall_ret_val) < 0) \ | |||
| { \ | |||
| libc_fatal ("Syscall successful", __FILE__, __FUNCTION__, __LINE__); \ | |||
| libc_fatal ("Syscall unsuccessful", __FILE__, __FUNCTION__, __LINE__); \ | |||
There was a problem hiding this comment.
Both messages are confusing, maybe just
libc_fatal ("Syscall", __FILE__, __FUNCTION__, __LINE__);?
Added declaration and implementations of `void abort (void)` to jerry-libc. As the linux implementation relies on the `getpid` syscall - which has no arguments - `syscall_0` implementations have been added as well. `libc_fatal` has been adapted to use the new `abort` function instead of `exit`. This also made the definition of `LIBC_FATAL_ERROR_EXIT_CODE` unnecessary. Finally, the syscall fatal error message was fixed. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
|
Updated according to comment |
|
Great, |
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added declaration and implementations of
void abort (void)tojerry-libc. As the linux implementation relies on the
getpidsyscall - which has no arguments -
syscall_0implementationshave been added as well.
libc_fatalhas been adapted to use the newabortfunctioninstead of
exit. This also made the definition ofLIBC_FATAL_ERROR_EXIT_CODEunnecessary.Finally, the syscall fatal error message was fixed.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu