Improvements for ecma_op_general_object_define_own_property #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruben-ayrapetyan
added
bug
|
Looks good to me. |
|
The problem is that this patch by itself would only lead to a different assert mentioned in the #132 issue. I was thinking that I'll add the fix for that also into this PR and then it should pass the testes correctly. What do you think? Can I have a PR which fixes two issues or should I stick with one issue fix per PR? |
|
I think, in the case, as the two issues are related to one case in one function (change of |
galpeter
changed the title
|
Ok, I've update the PR containing the fixes for both issues. |
|
Changes, related to both issues, look good to me. |
|
|
List of improvements: - Get the [[Enumerable]] and [[Configurable]] attributes before removing a property. - Directly check the type of the property in asserts. Related issues: #115 and #132 JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com
This was referenced May 17, 2020
This was referenced Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of improvements:
Related issues: #115 and #132
JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com