More gc-friendly property hashmap allocation. #1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
added
enhancement
| ecma_property_hashmap_free (obj_iter_p); | ||
| } | ||
|
|
||
| } |
ktorpi
force-pushed
the
property_hashmap_allocation
branch
from
cab46be to
52a9ca9
Compare
| @@ -110,7 +110,12 @@ ecma_property_hashmap_create (ecma_object_t *object_p) /**< object */ | |||
|
|
|||
| size_t total_size = ECMA_PROPERTY_HASHMAP_GET_TOTAL_SIZE (max_property_count); | |||
|
|
|||
| ecma_property_hashmap_t *hashmap_p = (ecma_property_hashmap_t *) jmem_heap_alloc_block (total_size); | |||
| ecma_property_hashmap_t *hashmap_p = (ecma_property_hashmap_t *) jmem_heap_alloc_block_null_on_error (total_size); | |||
| if (hashmap_p == NULL) | |||
There was a problem hiding this comment.
Perhaps we could think about a strategy what should happen if we are on low-memory conditions.
There was a problem hiding this comment.
Style: add a newline before the 'if'.
|
LGTM |
ktorpi
force-pushed
the
property_hashmap_allocation
branch
from
52a9ca9 to
d79cec6
Compare
| return jmem_heap_gc_and_alloc_block (size); | ||
| } /* jmem_heap_alloc_block_null_on_error */ | ||
|
|
||
|
|
ktorpi
force-pushed
the
property_hashmap_allocation
branch
from
d79cec6 to
2e16019
Compare
|
After the newline is added, LGTM. |
ktorpi
force-pushed
the
property_hashmap_allocation
branch
from
2e16019 to
6da9180
Compare
|
I've added the new line. |
|
@ktorpi, please rebase |
- New allocator is added that returns null on out of memory, property hasmap create uses this allocator for now. - Property hashmaps of objects are removed durring a high severity gc. Follow up patch is in progress. JerryScript-DCO-1.0-Signed-off-by: István Kádár ikadar@inf.u-szeged.hu
ktorpi
force-pushed
the
property_hashmap_allocation
branch
from
6da9180 to
e7ec053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up patch is in progress.
JerryScript-DCO-1.0-Signed-off-by: István Kádár ikadar@inf.u-szeged.hu