Check error values in API functions #1167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please check the travis fails. |
LaszloLango
force-pushed
the
jerry-api-error-handling
branch
from
74342a9 to
886477c
Compare
| @@ -62,6 +62,8 @@ static jerry_flag_t jerry_flags; | |||
| */ | |||
| static bool jerry_api_available; | |||
|
|
|||
| static const jerry_char_t *error_value_msg_p = (const jerry_char_t *) "argument cannot be an error value"; | |||
There was a problem hiding this comment.
"cannot have an error flag" is better
LaszloLango
force-pushed
the
jerry-api-error-handling
branch
from
886477c to
4f4f916
Compare
|
@zherczeg, I've updated the PR. Please check. |
| @@ -144,6 +144,7 @@ bool jerry_value_to_boolean (const jerry_value_t); | |||
| jerry_value_t jerry_value_to_number (const jerry_value_t); | |||
| jerry_value_t jerry_value_to_object (const jerry_value_t); | |||
| jerry_value_t jerry_value_to_string (const jerry_value_t); | |||
| jerry_value_t jerry_value_to_normal_value (const jerry_value_t); | |||
There was a problem hiding this comment.
what about jerry_value_remove_error_flag? I don't think people will understand the "normal" phrase.
There was a problem hiding this comment.
I don't mind to change it.
LaszloLango
force-pushed
the
jerry-api-error-handling
branch
from
4f4f916 to
1a0127b
Compare
|
I was thinking, and I convinced myself that the current approach is right. |
Internal functions cannot handle error values, so it must be avoided to pass error values to the engine. JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
LaszloLango
force-pushed
the
jerry-api-error-handling
branch
from
1a0127b to
c3541c3
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal functions cannot handle error values, so it must be avoided to
pass error values to the engine.
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com