Documentation is moved to docs. #1166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ktorpi
commented
Jun 22, 2016
ktorpi
commented
- DEVELOPEMENT.md is extended with bash utilites
- Internals doc added and DEVELOPEMENT.md is renamed to GETTING-STARTED.md
- modified image links in Internlas
- links are fixed in README.md
|
Signed-off-by message is incorrect. Please fix it. LGTM after that |
LaszloLango
added
enhancement
ktorpi
force-pushed
the
documentation_emplacement
branch
2 times, most recently
from
52ff017 to
ff642f4
Compare
|
LGTM |
| # High-Level Design | ||
|  | ||
|
|
||
| On the diagram above is shown interaction of major components of JerryScript: Parser and Virtual Machine (VM). Parser performs translation of input ECMAScript application into the byte-code with the specified format (refer to [Bytecode](#byte-code) and [Parser](#parser) page for details). Prepared bytecode is executed by the Virtual Machine that performs interpretation (refer to [Virtual Machine](#virtual-machine) and [ECMA](#ecma) pages for details). |
There was a problem hiding this comment.
The first sentence is a little bit funky. Maybe something like The diagram above shows interactions between major components...?
There was a problem hiding this comment.
You are right, I've fixed it.
ktorpi
force-pushed
the
documentation_emplacement
branch
2 times, most recently
from
cc127f2 to
818547e
Compare
|
LGTM |
|
Spotted a couple of typos in the commit message: DEVELOPEMENT.md is extended with bash utilites -> DEVELOPMENT.md is extended with bash utilities Otherwise LGTM :) |
ktorpi
force-pushed
the
documentation_emplacement
branch
from
818547e to
69761da
Compare
|
I've updated the commit message. |
ktorpi
force-pushed
the
documentation_emplacement
branch
from
69761da to
fe7e4c1
Compare
- DEVELOPMENT.md is extended with bash utilites. - Internals doc added and DEVELOPMENT is renamed to GETTING-STARTED. - modified image links in Internals - links are fixed in README.md JerryScript-DCO-1.0-Signed-off-by: István Kádár ikadar@inf.u-szeged.hu
ktorpi
force-pushed
the
documentation_emplacement
branch
from
fe7e4c1 to
1b40af7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.