Remove LIST_LAZY_PROPERTY_NAMES_ROUTINE_NAME macro function. #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| lowercase_name) \ | ||
| ecma_builtin_ ## lowercase_name ## _property_descriptor_list, | ||
| #include "ecma-builtins.inc.h" | ||
| }; |
Contributor
There was a problem hiding this comment.
Don't we need #undef BUILTIN here?
Member
Author
There was a problem hiding this comment.
That is part of ecma-builtins.inc.h
LaszloLango
added
enhancement
Member
Author
|
Patch updated. |
Contributor
|
LGTM |
zherczeg
force-pushed
the
lazy_enum_opt
branch
2 times, most recently
from
0563438 to
e16a358
Compare
Member
|
LGTM |
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8K binary save (164K -> 156K), a small slowdown (1%). I think 8K worth it.