Skip to content

Rename ecma_is_value_error to ECMA_IS_VALUE_ERROR. #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2016

Conversation

zherczeg
Copy link
Member

Telling the compiler that error is rare we get another performance improvement:

Benchmark Perf (sec)
3d-cube.js 1.166 -> 1.168 : -0.110%
3d-raytrace.js 1.404 -> 1.397 : +0.495%
access-binary-trees.js 0.714 -> 0.707 : +1.002%
access-fannkuch.js 2.831 -> 2.815 : +0.583%
access-nbody.js 1.404 -> 1.390 : +0.999%
bitops-3bit-bits-in-byte.js 0.650 -> 0.642 : +1.246%
bitops-bits-in-byte.js 0.947 -> 0.926 : +2.233%
bitops-bitwise-and.js 1.980 -> 1.847 : +6.726%
bitops-nsieve-bits.js 2.242 -> 2.250 : -0.336%
controlflow-recursive.js 0.495 -> 0.488 : +1.339%
crypto-aes.js 1.288 -> 1.302 : -1.086%
crypto-md5.js 0.877 -> 0.854 : +2.649%
crypto-sha1.js 0.814 -> 0.799 : +1.935%
date-format-tofte.js 1.083 -> 1.079 : +0.352%
date-format-xparb.js 0.563 -> 0.547 : +2.865%
math-cordic.js 1.730 -> 1.666 : +3.734%
math-partial-sums.js 0.981 -> 0.964 : +1.723%
math-spectral-norm.js 0.713 -> 0.719 : -0.894%
string-base64.js 4.631 -> 4.602 : +0.613%
string-fasta.js 2.170 -> 2.154 : +0.751%
Geometric mean: +1.356%

Binary size not changed.

JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
@dbatyai
Copy link
Member

dbatyai commented Jun 14, 2016

LGTM

1 similar comment
@LaszloLango
Copy link
Contributor

LGTM

@zherczeg zherczeg merged commit b828d4a into jerryscript-project:master Jun 14, 2016
@zherczeg zherczeg deleted the is_value_error branch June 14, 2016 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants