Skip to content

Improve get-value #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zherczeg
Copy link
Member

Slight perf improvement. But 4% on access-fannkuch.js

Benchmark Perf (sec)
3d-cube.js 1.210 -> 1.178 : +2.620%
3d-raytrace.js 1.468 -> 1.415 : +3.627%
access-binary-trees.js 0.727 -> 0.730 : -0.408%
access-fannkuch.js 2.980 -> 2.837 : +4.802%
access-nbody.js 1.481 -> 1.408 : +4.900%
bitops-3bit-bits-in-byte.js 0.645 -> 0.651 : -0.937%
bitops-bits-in-byte.js 0.944 -> 0.942 : +0.160%
bitops-bitwise-and.js 1.971 -> 1.999 : -1.376%
bitops-nsieve-bits.js 2.284 -> 2.275 : +0.397%
controlflow-recursive.js 0.495 -> 0.497 : -0.348%
crypto-aes.js 1.360 -> 1.303 : +4.137%
crypto-md5.js 0.865 -> 0.872 : -0.803%
crypto-sha1.js 0.810 -> 0.812 : -0.270%
date-format-tofte.js 1.098 -> 1.088 : +0.924%
date-format-xparb.js 0.569 -> 0.578 : -1.470%
math-cordic.js 1.726 -> 1.715 : +0.659%
math-partial-sums.js 1.009 -> 1.008 : +0.123%
math-spectral-norm.js 0.737 -> 0.714 : +3.046%
string-base64.js 4.611 -> 4.629 : -0.388%
string-fasta.js 2.190 -> 2.178 : +0.565%
Geometric mean: +1.019%

Binary size unchanged.

@LaszloLango LaszloLango added enhancement An improvement performance Affects performance labels Jun 13, 2016
@LaszloLango
Copy link
Contributor

That do { ... } while (0) style is bit odd to me, but nice improvement. If we cannot use a more common if-else style here with similar performance results, then it will be good in this form. LGTM

@zherczeg zherczeg force-pushed the get_value_optimization branch from c45735f to 6a48d45 Compare June 14, 2016 08:25
@zherczeg
Copy link
Member Author

Patch updated.

@LaszloLango
Copy link
Contributor

@zherczeg, thanks for the updated. LGTM

JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
@dbatyai
Copy link
Member

dbatyai commented Jun 14, 2016

LGTM

@zherczeg zherczeg force-pushed the get_value_optimization branch from 6a48d45 to 1eeed7e Compare June 14, 2016 09:24
@zherczeg zherczeg merged commit 1eeed7e into jerryscript-project:master Jun 14, 2016
@zherczeg zherczeg deleted the get_value_optimization branch June 14, 2016 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement performance Affects performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants