Skip to content

Optimize put result phase in the interpreter. #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2016

Conversation

zherczeg
Copy link
Member

Skip put result phase for opcodes which put their
result onto the stack or they don't have result at all.

Slight performance improvement:

Benchmark Perf (sec)
3d-cube.js 1.257 -> 1.210 : +3.758%
3d-raytrace.js 1.498 -> 1.468 : +1.969%
access-binary-trees.js 0.732 -> 0.727 : +0.698%
access-fannkuch.js 2.949 -> 2.980 : -1.069%
access-nbody.js 1.505 -> 1.481 : +1.633%
bitops-3bit-bits-in-byte.js 0.669 -> 0.645 : +3.665%
bitops-bits-in-byte.js 0.985 -> 0.944 : +4.166%
bitops-bitwise-and.js 1.989 -> 1.971 : +0.901%
bitops-nsieve-bits.js 2.346 -> 2.284 : +2.613%
controlflow-recursive.js 0.507 -> 0.495 : +2.383%
crypto-aes.js 1.360 -> 1.360 : +0.032%
crypto-md5.js 0.872 -> 0.865 : +0.763%
crypto-sha1.js 0.820 -> 0.810 : +1.220%
date-format-tofte.js 1.133 -> 1.098 : +3.123%
date-format-xparb.js 0.587 -> 0.569 : +3.016%
math-cordic.js 1.771 -> 1.726 : +2.533%
math-partial-sums.js 1.033 -> 1.009 : +2.301%
math-spectral-norm.js 0.757 -> 0.737 : +2.673%
string-base64.js 4.631 -> 4.611 : +0.436%
string-fasta.js 2.191 -> 2.190 : +0.063%
Geometric mean: +1.854%

Skip put result phase for opcodes which put their
result onto the stack or they don't have result at all.

JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
@LaszloLango LaszloLango added enhancement An improvement performance Affects performance labels Jun 10, 2016
@dbatyai
Copy link
Member

dbatyai commented Jun 13, 2016

LGTM

1 similar comment
@LaszloLango
Copy link
Contributor

LGTM

@zherczeg zherczeg merged commit 495b24e into jerryscript-project:master Jun 13, 2016
@zherczeg zherczeg deleted the optimize_push_result branch June 13, 2016 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement performance Affects performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants