Update API functions #1124
Merged
Update API functions #1124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we accept this PR, then I'll add an additional commit to the PR that updates the names in the related documentations. |
| * just when it becomes unnecessary. | ||
| */ | ||
| static void | ||
| jerry_api_convert_ecma_value_to_api_value (jerry_api_value_t *out_value_p, /**< [out] api value */ | ||
| jerry_convert_ecma_value_to_api_value (jerry_value_t *out_value_p, /**< [out] api value */ |
|
Good. LGTM |
LaszloLango
force-pushed
the
jerry-api-update
branch
from
2ee3d5e to
0b7b6fe
Compare
|
LGTM |
* Rename 'jerry_api_' prefix to 'jerry_' * Fix minor style issues * Group the API functions and add comment to each group * Move engine behaviour related funtions to 'jerry.h' JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
LaszloLango
force-pushed
the
jerry-api-update
branch
from
bc0e352 to
b5efa2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com