Skip to content

Remove last_completion_value. #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zherczeg
Copy link
Member

@zherczeg zherczeg commented Jun 3, 2016

Code cleaning, not much effect on performance.

Benchmark Perf (sec)
3d-cube.js 1.490 -> 1.497 : -0.507%
3d-raytrace.js 1.539 -> 1.551 : -0.763%
access-binary-trees.js 0.763 -> 0.764 : -0.165%
access-fannkuch.js 3.253 -> 3.164 : +2.724%
access-nbody.js 1.589 -> 1.575 : +0.901%
bitops-3bit-bits-in-byte.js 0.793 -> 0.799 : -0.744%
bitops-bits-in-byte.js 1.043 -> 1.050 : -0.681%
bitops-bitwise-and.js 1.945 -> 1.984 : -1.986%
bitops-nsieve-bits.js 2.559 -> 2.530 : +1.154%
controlflow-recursive.js 0.548 -> 0.552 : -0.563%
crypto-aes.js 1.480 -> 1.465 : +0.970%
crypto-md5.js 0.929 -> 0.926 : +0.311%
crypto-sha1.js 0.872 -> 0.871 : +0.109%
date-format-tofte.js 1.173 -> 1.177 : -0.343%
date-format-xparb.js 0.612 -> 0.598 : +2.264%
math-cordic.js 2.000 -> 2.007 : -0.341%
math-partial-sums.js 1.124 -> 1.100 : +2.121%
math-spectral-norm.js 0.888 -> 0.893 : -0.560%
string-base64.js 4.736 -> 4.691 : +0.951%
string-fasta.js 2.267 -> 2.225 : +1.865%
Geometric mean: +0.343%

@LaszloLango LaszloLango added the enhancement An improvement label Jun 3, 2016
@@ -320,7 +320,7 @@ ecma_is_value_object (ecma_value_t value) /**< ecma value */
inline bool __attr_pure___ __attr_always_inline___
ecma_is_value_error (ecma_value_t value) /**< ecma value */
{
return (value & ECMA_VALUE_ERROR_FLAG) != 0;
return unlikely ((value & ECMA_VALUE_ERROR_FLAG) != 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks unrelated. Do we really need it in this patch?

JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
@zherczeg zherczeg force-pushed the remove_last_completion_value branch from 9f8a465 to 308bb3c Compare June 3, 2016 11:13
@zherczeg
Copy link
Member Author

zherczeg commented Jun 3, 2016

Removed

@LaszloLango
Copy link
Contributor

@zherczeg, thanks. LGTM

@dbatyai
Copy link
Member

dbatyai commented Jun 3, 2016

LGTM

@zherczeg zherczeg merged commit 308bb3c into jerryscript-project:master Jun 3, 2016
@zherczeg zherczeg deleted the remove_last_completion_value branch June 3, 2016 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants