-
Notifications
You must be signed in to change notification settings - Fork 683
Improve equal operations. #1120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve equal operations. #1120
Conversation
Please measure the PR on RPi2. |
Since equal is not a frequent operation, the difference is not big. Although it slightly improved the perf in 12 cases.
Binary sizes (bytes) However, the binary size is decreased by 300 bytes, which is useful. |
{ | ||
// 1. | ||
// Note: the (x == y) comparison captures the true case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also fix comments in the touched functions? (// -> /* */
)
LGTM |
415d013
to
d917467
Compare
@@ -20,6 +20,7 @@ | |||
#include "ecma-array-object.h" | |||
#include "ecma-builtins.h" | |||
#include "ecma-conversion.h" | |||
#include "ecma-comparison.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be above ecma-conversion.h
LGTM after the include is fixed |
The implementation is simplified and optimized resulting the removal a large amount of code. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
d917467
to
6f33ab3
Compare
The code is simplified a lot (a lot of code is deleted).