Modify the usage of ecma_string_to_utf8_string() #1119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -674,7 +671,7 @@ ecma_string_get_array_index (const ecma_string_t *str_p, /**< ecma-string */ | |||
| * | |||
| * @return number of bytes, actually copied to the buffer. | |||
| */ | |||
| lit_utf8_size_t __attr_return_value_should_be_checked___ | |||
| lit_utf8_size_t | |||
There was a problem hiding this comment.
Do we use the return value anywhere?
bzsolt
force-pushed
the
modify-string-to-utf8-string
branch
from
6854ef8 to
dcdf698
Compare
|
Thanks for the reviews, I've updated the PR. |
| * (can be NULL if buffer_size == 0) */ | ||
| lit_utf8_size_t buffer_size) /**< size of buffer */ | ||
| { | ||
| JERRY_ASSERT (ecma_string_get_size (string_desc_p) == buffer_size); |
There was a problem hiding this comment.
I think this assert is unnecessary, since the <= is checked by ecma_string_copy_to_utf8_buffer and size == buffer_size checks the equality.
|
LGTM after that |
bzsolt
force-pushed
the
modify-string-to-utf8-string
branch
from
dcdf698 to
4a2f9d5
Compare
|
LGTM |
1 similar comment
|
LGTM |
Parts: * Rename ecma_string_to_utf8_string() to ecma_string_copy_to_utf8_buffer. * Introduce ecma_string_to_utf8_bytes(), which wraps the usual 'function call-assertion' pair, and check strict equality of size of the string and the buffer. JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély zsborbely.u-szeged@partner.samsung.com
bzsolt
force-pushed
the
modify-string-to-utf8-string
branch
from
4a2f9d5 to
c557a0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parts:
is already checked by the function itself, therefore we can remove some
local variables, which serves this purpose.
and remove the attribute itself, because it became unused in the project.
JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély zsborbely.u-szeged@partner.samsung.com