Improve empty checks of ecma strings #1113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
added
enhancement
Contributor
Author
|
| return true; | ||
| } | ||
|
|
||
| return false; |
Member
There was a problem hiding this comment.
I think you can simply write:
return (logical_exp)
LaszloLango
force-pushed
the
ecma-is-empty-ecma-string
branch
from
8d45fb7 to
b1583c7
Compare
|
|
||
| /* 8.b.iii */ | ||
| bool is_gap_empty = (ecma_string_get_length (context_p->gap_str_p) == 0); | ||
| bool is_gap_empty = (ecma_string_is_empty (context_p->gap_str_p)); |
Member
There was a problem hiding this comment.
These could be placed inside their respective ifs without an intermediate variable.
LaszloLango
force-pushed
the
ecma-is-empty-ecma-string
branch
from
b1583c7 to
91f43b9
Compare
LaszloLango
force-pushed
the
ecma-is-empty-ecma-string
branch
from
91f43b9 to
69435cc
Compare
Contributor
Author
|
@zherczeg, @akiss77, I've rebased to the current master. Please check. |
LaszloLango
force-pushed
the
ecma-is-empty-ecma-string
branch
from
69435cc to
f26990e
Compare
Member
|
LGTM |
LaszloLango
force-pushed
the
ecma-is-empty-ecma-string
branch
from
f26990e to
5d16024
Compare
Member
|
LGTM |
LaszloLango
force-pushed
the
ecma-is-empty-ecma-string
branch
from
5d16024 to
7f153c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com