Skip to content

Remove ECMA_STRING_CONTAINER_HEAP_NUMBER. #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2016

Conversation

zherczeg
Copy link
Member

Does not provide a gain:

Benchmark Perf (sec)
3d-cube.js 1.806 -> 1.792 : +0.796%
3d-raytrace.js 2.054 -> 2.004 : +2.451%
access-binary-trees.js 0.868 -> 0.861 : +0.737%
access-fannkuch.js 4.033 -> 3.925 : +2.668%
access-nbody.js 2.123 -> 2.084 : +1.841%
bitops-3bit-bits-in-byte.js 0.818 -> 0.821 : -0.328%
bitops-bits-in-byte.js 1.150 -> 1.135 : +1.296%
bitops-bitwise-and.js 1.899 -> 1.907 : -0.416%
bitops-nsieve-bits.js 2.872 -> 2.870 : +0.066%
controlflow-recursive.js 0.566 -> 0.563 : +0.545%
crypto-aes.js 2.013 -> 1.985 : +1.387%
crypto-md5.js 1.013 -> 0.995 : +1.699%
crypto-sha1.js 0.946 -> 0.928 : +1.891%
date-format-tofte.js 1.501 -> 1.487 : +0.975%
date-format-xparb.js 0.672 -> 0.654 : +2.717%
math-cordic.js 2.103 -> 2.066 : +1.760%
math-partial-sums.js 1.126 -> 1.108 : +1.570%
math-spectral-norm.js 0.980 -> 0.980 : +0.051%
string-base64.js 4.959 -> 4.921 : +0.772%
string-fasta.js 2.454 -> 2.436 : +0.762%
Geometric mean: +1.166%

0.4K binary saving

@zherczeg zherczeg force-pushed the remove_heap_number branch from e606cda to ca711cf Compare May 30, 2016 10:53

JERRY_ASSERT (!lit_is_utf8_string_magic (str_buf, str_size, &magic_string_id)
&& !lit_is_ex_utf8_string_magic (str_buf, str_size, &magic_string_ex_id));
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing comment: /* !JERRY_NDEBUG */

@LaszloLango
Copy link
Contributor

LGTM

@LaszloLango LaszloLango added enhancement An improvement performance Affects performance labels May 30, 2016
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
@zherczeg zherczeg force-pushed the remove_heap_number branch from ca711cf to 08c312b Compare May 30, 2016 12:10
@zherczeg
Copy link
Member Author

Thanks, fixed

@dbatyai
Copy link
Member

dbatyai commented May 30, 2016

LGTM

@zherczeg zherczeg merged commit 08c312b into jerryscript-project:master May 30, 2016
@zherczeg zherczeg deleted the remove_heap_number branch May 30, 2016 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement performance Affects performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants