Unify the condition form within the asserts #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM (please fix commit message: "can be represented") |
robertsipka
force-pushed
the
type_conversion
branch
from
ebe571a to
0decf86
Compare
|
Thanks, fixed. |
| JERRY_ASSERT ( name[0] <= UINT32_MAX); \ | ||
| JERRY_ASSERT ( name[1] <= UINT32_MAX); \ | ||
| JERRY_ASSERT ( name[2] <= UINT32_MAX); \ | ||
| JERRY_ASSERT ( name[3] <= UINT32_MAX); \ |
There was a problem hiding this comment.
unnecessary space in front of name.
JERRY_ASSERT (name[0] <= UINT32_MAX);
...
There was a problem hiding this comment.
Why do you added a space before name?
There was a problem hiding this comment.
Ohh, thanks, it was remiss of me.
robertsipka
force-pushed
the
type_conversion
branch
from
0decf86 to
7acc5c8
Compare
|
LGTM |
|
LGTM |
This modificiation affects those conditions which check that a value can be represented with a smaller type. JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
robertsipka
force-pushed
the
type_conversion
branch
from
7acc5c8 to
1c028d9
Compare
|
I rebased it with the master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modificiation affects those conditions which check that
a value can be representable with a smaller type.
JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com